[#38] added lint and used the lint suggestions

forms/admin_password_reset_confirm_test.go

@@ -107,7 +107,7 @@ func TestAdminPasswordResetConfirmSubmit(t *testing.T) {
 		}
 
 		claims, _ := security.ParseUnverifiedJWT(s.token)
-		tokenAdminId, _ := claims["id"]
+		tokenAdminId := claims["id"]
 
 		if admin.Id != tokenAdminId {
 			t.Errorf("(%d) Expected admin with id %s to be returned, got %v", i, tokenAdminId, admin)

forms/collection_upsert.go

@@ -95,7 +95,7 @@ func (form *CollectionUpsert) checkUniqueName(value any) error {
 		return validation.NewError("validation_collection_name_exists", "Collection name must be unique (case insensitive).")
 	}
 
-	if (form.isCreate || strings.ToLower(v) != strings.ToLower(form.collection.Name)) && form.app.Dao().HasTable(v) {
+	if (form.isCreate || !strings.EqualFold(v, form.collection.Name)) && form.app.Dao().HasTable(v) {
 		return validation.NewError("validation_collection_name_table_exists", "The collection name must be also unique table name.")
 	}
 

forms/record_upsert.go

@@ -44,7 +44,6 @@ func NewRecordUpsert(app core.App, record *models.Record) *RecordUpsert {
 	form.Data = map[string]any{}
 	for _, field := range record.Collection().Schema.Fields() {
 		form.Data[field.Name] = record.GetDataValue(field.Name)
-
 	}
 
 	return form
@@ -147,7 +146,7 @@ func (form *RecordUpsert) LoadData(r *http.Request) error {
 
 	for _, field := range form.record.Collection().Schema.Fields() {
 		key := field.Name
-		value, _ := extendedData[key]
+		value := extendedData[key]
 		value = field.PrepareValue(value)
 
 		if field.Type == schema.FieldTypeFile {

forms/record_upsert_test.go

@@ -29,7 +29,7 @@ func TestNewRecordUpsert(t *testing.T) {
 
 	form := forms.NewRecordUpsert(app, record)
 
-	val, _ := form.Data["title"]
+	val := form.Data["title"]
 	if val != "test_value" {
 		t.Errorf("Expected record data to be load, got %v", form.Data)
 	}

forms/user_oauth2_login.go

@@ -68,7 +68,7 @@ func (form *UserOauth2Login) Submit() (*models.User, *auth.AuthUser, error) {
 		return nil, nil, err
 	}
 
-	config, _ := form.app.Settings().NamedAuthProviderConfigs()[form.Provider]
+	config := form.app.Settings().NamedAuthProviderConfigs()[form.Provider]
 	config.SetupProvider(provider)
 
 	provider.SetRedirectUrl(form.RedirectUrl)

forms/user_password_reset_confirm_test.go

@@ -148,7 +148,7 @@ func TestUserPasswordResetConfirmSubmit(t *testing.T) {
 		}
 
 		claims, _ := security.ParseUnverifiedJWT(form.Token)
-		tokenUserId, _ := claims["id"]
+		tokenUserId := claims["id"]
 
 		if user.Id != tokenUserId {
 			t.Errorf("(%d) Expected user with id %s, got %v", i, tokenUserId, user)

forms/user_verification_confirm_test.go

@@ -127,7 +127,7 @@ func TestUserVerificationConfirmSubmit(t *testing.T) {
 		}
 
 		claims, _ := security.ParseUnverifiedJWT(form.Token)
-		tokenUserId, _ := claims["id"]
+		tokenUserId := claims["id"]
 
 		if user.Id != tokenUserId {
 			t.Errorf("(%d) Expected user.Id %q, got %q", i, tokenUserId, user.Id)

forms/validators/record_data.go

@@ -6,9 +6,9 @@ import (
 	"regexp"
 	"strings"
 
-	"github.com/pocketbase/dbx"
 	validation "github.com/go-ozzo/ozzo-validation/v4"
 	"github.com/go-ozzo/ozzo-validation/v4/is"
+	"github.com/pocketbase/dbx"
 	"github.com/pocketbase/pocketbase/daos"
 	"github.com/pocketbase/pocketbase/models"
 	"github.com/pocketbase/pocketbase/models/schema"

forms/validators/record_data_test.go

@@ -1189,7 +1189,7 @@ func TestRecordDataValidatorValidateRelation(t *testing.T) {
 			Type: schema.FieldTypeRelation,
 			Options: &schema.RelationOptions{
 				MaxSelect:    3,
-				CollectionId: "", // missing or nonexisting colleciton id
+				CollectionId: "", // missing or non-existing collection id
 			},
 		},
 	)