added migration to normalize the system collection and field ids

migrations/1640988000_init.go

@@ -118,7 +118,7 @@ func createParamsTable(txApp core.App) error {
 }
 
 func createMFAsCollection(txApp core.App) error {
-	col := core.NewBaseCollection(core.CollectionNameMFAs, "_pbc"+core.CollectionNameMFAs)
+	col := core.NewBaseCollection(core.CollectionNameMFAs)
 	col.System = true
 
 	ownerRule := "@request.auth.id != '' && recordRef = @request.auth.id && collectionRef = @request.auth.collectionId"
@@ -157,7 +157,7 @@ func createMFAsCollection(txApp core.App) error {
 }
 
 func createOTPsCollection(txApp core.App) error {
-	col := core.NewBaseCollection(core.CollectionNameOTPs, "_pbc"+core.CollectionNameOTPs)
+	col := core.NewBaseCollection(core.CollectionNameOTPs)
 	col.System = true
 
 	ownerRule := "@request.auth.id != '' && recordRef = @request.auth.id && collectionRef = @request.auth.collectionId"
@@ -198,7 +198,7 @@ func createOTPsCollection(txApp core.App) error {
 }
 
 func createAuthOriginsCollection(txApp core.App) error {
-	col := core.NewBaseCollection(core.CollectionNameAuthOrigins, "_pbc"+core.CollectionNameAuthOrigins)
+	col := core.NewBaseCollection(core.CollectionNameAuthOrigins)
 	col.System = true
 
 	ownerRule := "@request.auth.id != '' && recordRef = @request.auth.id && collectionRef = @request.auth.collectionId"
@@ -238,7 +238,7 @@ func createAuthOriginsCollection(txApp core.App) error {
 }
 
 func createExternalAuthsCollection(txApp core.App) error {
-	col := core.NewBaseCollection(core.CollectionNameExternalAuths, "_pbc"+core.CollectionNameExternalAuths)
+	col := core.NewBaseCollection(core.CollectionNameExternalAuths)
 	col.System = true
 
 	ownerRule := "@request.auth.id != '' && recordRef = @request.auth.id && collectionRef = @request.auth.collectionId"
@@ -284,7 +284,7 @@ func createExternalAuthsCollection(txApp core.App) error {
 }
 
 func createSuperusersCollection(txApp core.App) error {
-	superusers := core.NewAuthCollection(core.CollectionNameSuperusers, "_pbc"+core.CollectionNameSuperusers)
+	superusers := core.NewAuthCollection(core.CollectionNameSuperusers)
 	superusers.System = true
 	superusers.Fields.Add(&core.EmailField{
 		Name:     "email",

migrations/1717233558_v0.23_migrate3.go

@@ -0,0 +1,138 @@
+package migrations
+
+import (
+	"hash/crc32"
+	"strconv"
+
+	"github.com/pocketbase/dbx"
+	"github.com/pocketbase/pocketbase/core"
+)
+
+// note: this migration will be deleted in future version
+
+func collectionIdChecksum(c *core.Collection) string {
+	return "pbc_" + strconv.Itoa(int(crc32.ChecksumIEEE([]byte(c.Type+c.Name))))
+}
+
+func fieldIdChecksum(f core.Field) string {
+	return f.Type() + strconv.Itoa(int(crc32.ChecksumIEEE([]byte(f.GetName()))))
+}
+
+// normalize system collection and field ids
+func init() {
+	core.SystemMigrations.Register(func(txApp core.App) error {
+		collections := []*core.Collection{}
+		err := txApp.CollectionQuery().
+			AndWhere(dbx.In(
+				"name",
+				core.CollectionNameMFAs,
+				core.CollectionNameOTPs,
+				core.CollectionNameExternalAuths,
+				core.CollectionNameAuthOrigins,
+				core.CollectionNameSuperusers,
+			)).
+			All(&collections)
+		if err != nil {
+			return err
+		}
+
+		for _, c := range collections {
+			var needUpdate bool
+
+			references, err := txApp.FindCollectionReferences(c, c.Id)
+			if err != nil {
+				return err
+			}
+
+			authOrigins, err := txApp.FindAllAuthOriginsByCollection(c)
+			if err != nil {
+				return err
+			}
+
+			mfas, err := txApp.FindAllMFAsByCollection(c)
+			if err != nil {
+				return err
+			}
+
+			otps, err := txApp.FindAllOTPsByCollection(c)
+			if err != nil {
+				return err
+			}
+
+			originalId := c.Id
+
+			// normalize collection id
+			if checksum := collectionIdChecksum(c); c.Id != checksum {
+				c.Id = checksum
+				needUpdate = true
+			}
+
+			// normalize system fields
+			for _, f := range c.Fields {
+				if !f.GetSystem() {
+					continue
+				}
+
+				if checksum := fieldIdChecksum(f); f.GetId() != checksum {
+					f.SetId(checksum)
+					needUpdate = true
+				}
+			}
+
+			if !needUpdate {
+				continue
+			}
+
+			rawExport, err := c.DBExport(txApp)
+			if err != nil {
+				return err
+			}
+
+			_, err = txApp.DB().Update("_collections", rawExport, dbx.HashExp{"id": originalId}).Execute()
+			if err != nil {
+				return err
+			}
+
+			// update collection references
+			for refCollection, fields := range references {
+				for _, f := range fields {
+					relationField, ok := f.(*core.RelationField)
+					if !ok || relationField.CollectionId == originalId {
+						continue
+					}
+
+					relationField.CollectionId = c.Id
+				}
+				if err = txApp.Save(refCollection); err != nil {
+					return err
+				}
+			}
+
+			// update mfas references
+			for _, item := range mfas {
+				item.SetCollectionRef(c.Id)
+				if err = txApp.Save(item); err != nil {
+					return err
+				}
+			}
+
+			// update otps references
+			for _, item := range otps {
+				item.SetCollectionRef(c.Id)
+				if err = txApp.Save(item); err != nil {
+					return err
+				}
+			}
+
+			// update authOrigins references
+			for _, item := range authOrigins {
+				item.SetCollectionRef(c.Id)
+				if err = txApp.Save(item); err != nil {
+					return err
+				}
+			}
+		}
+
+		return nil
+	}, nil)
+}