[#6063] fixed x-forwarded-for typo

This commit is contained in:
Gani Georgiev
2024-12-09 04:33:44 +02:00
parent 88a1867169
commit 9747f46c1d
34 changed files with 3869 additions and 3867 deletions
+7 -7
View File
@@ -17,7 +17,7 @@ func TestEventRequestRealIP(t *testing.T) {
"CF-Connecting-IP": {"1.2.3.4", "1.1.1.1"},
"Fly-Client-IP": {"1.2.3.4", "1.1.1.2"},
"X-Real-IP": {"1.2.3.4", "1.1.1.3,1.1.1.4"},
"X-Forward-For": {"1.2.3.4", "invalid,1.1.1.5,1.1.1.6,invalid"},
"X-Forwarded-For": {"1.2.3.4", "invalid,1.1.1.5,1.1.1.6,invalid"},
}
scenarios := []struct {
@@ -44,28 +44,28 @@ func TestEventRequestRealIP(t *testing.T) {
{
"trusted X-Real-IP (rightmost)",
headers,
[]string{"header1", "x-real-ip", "x-forward-for"},
[]string{"header1", "x-real-ip", "x-forwarded-for"},
false,
"1.1.1.4",
},
{
"trusted X-Real-IP (leftmost)",
headers,
[]string{"header1", "x-real-ip", "x-forward-for"},
[]string{"header1", "x-real-ip", "x-forwarded-for"},
true,
"1.1.1.3",
},
{
"trusted X-Forward-For (rightmost)",
"trusted X-Forwarded-For (rightmost)",
headers,
[]string{"header1", "x-forward-for"},
[]string{"header1", "x-forwarded-for"},
false,
"1.1.1.6",
},
{
"trusted X-Forward-For (leftmost)",
"trusted X-Forwarded-For (leftmost)",
headers,
[]string{"header1", "x-forward-for"},
[]string{"header1", "x-forwarded-for"},
true,
"1.1.1.5",
},
+1 -1
View File
@@ -530,7 +530,7 @@ type TrustedProxyConfig struct {
// UseLeftmostIP specifies to use the left-mostish IP from the trusted headers.
//
// Note that this could be insecure when used with X-Forward-For header
// Note that this could be insecure when used with X-Forwarded-For header
// because some proxies like AWS ELB allow users to prepend their own header value
// before appending the trusted ones.
UseLeftmostIP bool `form:"useLeftmostIP" json:"useLeftmostIP"`