cleaning up no longer needed ui helper methods

This commit is contained in:
Gani Georgiev
2022-07-31 23:20:58 +03:00
parent c070be2c47
commit 87ecb1114c
11 changed files with 105 additions and 204 deletions
+1 -16
View File
@@ -24,9 +24,8 @@
newKeyOfSelected = CommonHelper.toArray(newKeyOfSelected, true);
let newSelected = [];
let allItems = getFlattenItems();
for (let item of allItems) {
for (let item of items) {
if (CommonHelper.inArray(newKeyOfSelected, item[selectionKey])) {
newSelected.push(item);
}
@@ -48,20 +47,6 @@
keyOfSelected = multiple ? extractedKeys : extractedKeys[0];
}
function getFlattenItems() {
if (!CommonHelper.isObjectArrayWithKeys(items, ["group", "items"])) {
return items; // already flatten
}
// extract items from groups
let result = [];
for (const group of items) {
result = result.concat(group.items);
}
return result;
}
</script>
<Select bind:selected {items} {multiple} {labelComponent} {optionComponent} on:show on:hide {...$$restProps}>
+5 -12
View File
@@ -1,5 +1,4 @@
<script>
import CommonHelper from "@/utils/CommonHelper";
import OverlayPanel from "@/components/base/OverlayPanel.svelte";
let panel;
@@ -10,15 +9,9 @@
return;
}
CommonHelper.checkImageUrl(newUrl)
.then(() => {
url = newUrl;
panel?.show();
})
.catch(() => {
console.warn("Invalid image preview url: ", newUrl);
hide();
});
url = newUrl;
panel?.show();
}
export function hide() {
@@ -33,11 +26,11 @@
</div>
</svelte:fragment>
<img src={url} alt="Preview" />
<img src={url} alt="Preview {url}" />
<svelte:fragment slot="footer">
<a href={url} title="Download" class="link-hint txt-ellipsis">
/../{url.substring(url.lastIndexOf("/") + 1)}
{url.substring(url.lastIndexOf("/") + 1)}
</a>
<div class="flex-fill" />
<button type="button" class="btn btn-secondary" on:click={hide}>Close</button>