added db pool size limits and update the min go release action version to 1.19.3

core/db_cgo.go

@@ -5,18 +5,28 @@ package core
 import (
 	"fmt"
 
-	_ "github.com/mattn/go-sqlite3"
 	"github.com/pocketbase/dbx"
+	_ "github.com/mattn/go-sqlite3"
 )
 
 func connectDB(dbPath string) (*dbx.DB, error) {
-	pragmas := "_foreign_keys=1&_journal_mode=WAL&_synchronous=NORMAL&_busy_timeout=8000"
+	// note: the busy_timeout pragma must be first because
+	// the connection needs to be set to block on busy before WAL mode
+	// is set in case it hasn't been already set by another connection
+	pragmas := "_busy_timeout=10000&_journal_mode=WAL&_foreign_keys=1&_synchronous=NORMAL"
 
 	db, openErr := dbx.MustOpen("sqlite3", fmt.Sprintf("%s?%s", dbPath, pragmas))
 	if openErr != nil {
 		return nil, openErr
 	}
 
+	// use a fixed connection pool to limit the SQLITE_BUSY errors
+	// and reduce the open file descriptors
+	// (the limits are arbitrary and may change in the future)
+	db.DB().SetMaxOpenConns(500)
+	db.DB().SetMaxIdleConns(30)
+	db.DB().SetConnMaxIdleTime(5 * time.Minute)
+
 	// additional pragmas not supported through the dsn string
 	_, err := db.NewQuery(`
 		pragma journal_size_limit = 100000000;

core/db_nocgo.go

@@ -4,13 +4,31 @@ package core
 
 import (
 	"fmt"
+	"time"
 
 	"github.com/pocketbase/dbx"
 	_ "modernc.org/sqlite"
 )
 
 func connectDB(dbPath string) (*dbx.DB, error) {
-	pragmas := "_pragma=foreign_keys(1)&_pragma=journal_mode(WAL)&_pragma=synchronous(NORMAL)&_pragma=busy_timeout(8000)&_pragma=journal_size_limit(100000000)"
+	// note: the busy_timeout pragma must be first because
+	// the connection needs to be set to block on busy before WAL mode
+	// is set in case it hasn't been already set by another connection
+	pragmas := "_pragma=busy_timeout(10000)&_pragma=journal_mode(WAL)&_pragma=foreign_keys(1)&_pragma=synchronous(NORMAL)&_pragma=journal_size_limit(100000000)"
 
-	return dbx.MustOpen("sqlite", fmt.Sprintf("%s?%s", dbPath, pragmas))
+	db, err := dbx.MustOpen("sqlite", fmt.Sprintf("%s?%s", dbPath, pragmas))
+	if err != nil {
+		return nil, err
+	}
+
+	// use a fixed connection pool to limit the SQLITE_BUSY errors and
+	// reduce the open file descriptors
+	// (the limits are arbitrary and may change in the future)
+	//
+	// @see https://gitlab.com/cznic/sqlite/-/issues/115
+	db.DB().SetMaxOpenConns(500)
+	db.DB().SetMaxIdleConns(30)
+	db.DB().SetConnMaxIdleTime(5 * time.Minute)
+
+	return db, nil
 }