[#4607] fixed the keyboard-accebility of the Admin UI dropdowns

This commit is contained in:
Gani Georgiev
2024-03-22 20:06:18 +02:00
parent b596bbdc3e
commit 0122d4f527
48 changed files with 552 additions and 453 deletions
@@ -263,6 +263,7 @@
}
</script>
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<OverlayPanel
bind:this={collectionPanel}
class="overlay-panel-lg colored-header collection-panel"
@@ -288,23 +289,34 @@
{#if !!collection.id && !collection.system}
<div class="flex-fill" />
<button type="button" aria-label="More" class="btn btn-sm btn-circle btn-transparent flex-gap-0">
<i class="ri-more-line" />
<div
tabindex="0"
role="button"
aria-label="More collection options"
class="btn btn-sm btn-circle btn-transparent flex-gap-0"
>
<i class="ri-more-line" aria-hidden="true" />
<Toggler class="dropdown dropdown-right m-t-5">
<button type="button" class="dropdown-item closable" on:click={() => duplicateConfirm()}>
<i class="ri-file-copy-line" />
<button
type="button"
class="dropdown-item"
role="menuitem"
on:click={() => duplicateConfirm()}
>
<i class="ri-file-copy-line" aria-hidden="true" />
<span class="txt">Duplicate</span>
</button>
<button
type="button"
class="dropdown-item txt-danger closable"
class="dropdown-item txt-danger"
role="menuitem"
on:click|preventDefault|stopPropagation={() => deleteConfirm()}
>
<i class="ri-delete-bin-7-line" />
<i class="ri-delete-bin-7-line" aria-hidden="true" />
<span class="txt">Delete</span>
</button>
</Toggler>
</button>
</div>
{/if}
<form
@@ -337,31 +349,37 @@
/>
<div class="form-field-addon">
<button
type="button"
<div
tabindex={!collection.id ? 0 : -1}
role={!collection.id ? "button" : ""}
aria-label="View types"
class="btn btn-sm p-r-10 p-l-10 {!collection.id ? 'btn-outline' : 'btn-transparent'}"
disabled={!!collection.id}
class:btn-disabled={!!collection.id}
>
<!-- empty span for alignment -->
<span />
<span aria-hidden="true" />
<span class="txt">Type: {collectionTypes[collection.type] || "N/A"}</span>
{#if !collection.id}
<i class="ri-arrow-down-s-fill" />
<i class="ri-arrow-down-s-fill" aria-hidden="true" />
<Toggler class="dropdown dropdown-right dropdown-nowrap m-t-5">
{#each Object.entries(collectionTypes) as [type, label]}
<button
type="button"
role="menuitem"
class="dropdown-item closable"
class:selected={type == collection.type}
on:click={() => setCollectionType(type)}
>
<i class={CommonHelper.getCollectionTypeIcon(type)} />
<i
class={CommonHelper.getCollectionTypeIcon(type)}
aria-hidden="true"
/>
<span class="txt">{label} collection</span>
</button>
{/each}
</Toggler>
{/if}
</button>
</div>
</div>
{#if collection.system}
@@ -71,29 +71,18 @@
}
</script>
<button type="button" class="field-types-btn {classes}" on:click={dispatch}>
<i class="ri-add-line" />
<div tabindex="0" role="button" class="field-types-btn {classes}">
<i class="ri-add-line" aria-hidden="true" />
<div class="txt">New field</div>
<Toggler class="dropdown field-types-dropdown">
{#each types as item}
<div
tabindex="0"
class="dropdown-item closable"
on:click|stopPropagation={() => {
select(item.value);
}}
on:keydown|stopPropagation={(e) => {
if (e.code === "Enter" || e.code === "Space") {
select(item.value);
}
}}
>
<i class="icon {item.icon}" />
<button type="button" role="menuitem" class="dropdown-item" on:click={() => select(item.value)}>
<i class="icon {item.icon}" aria-hidden="true" />
<span class="txt">{item.label}</span>
</div>
</button>
{/each}
</Toggler>
</button>
</div>
<style lang="scss">
.field-types-btn.active {
@@ -244,22 +244,28 @@
{#if !field.toDelete}
<div class="m-l-auto txt-right">
<div class="inline-flex flex-gap-sm flex-nowrap">
<!-- svelte-ignore a11y-no-noninteractive-tabindex -->
<div tabindex="0" aria-label="More" class="btn btn-circle btn-sm btn-transparent">
<i class="ri-more-line" />
<div
tabindex="0"
role="button"
aria-label="More"
class="btn btn-circle btn-sm btn-transparent"
>
<i class="ri-more-line" aria-hidden="true" />
<Toggler
class="dropdown dropdown-sm dropdown-upside dropdown-right dropdown-nowrap no-min-width"
>
<button
type="button"
class="dropdown-item txt-right"
class="dropdown-item"
role="menuitem"
on:click|preventDefault={duplicate}
>
<span class="txt">Duplicate</span>
</button>
<button
type="button"
class="dropdown-item txt-right"
class="dropdown-item"
role="menuitem"
on:click|preventDefault={remove}
>
<span class="txt">Remove</span>
@@ -117,13 +117,19 @@
bind:keyOfSelected={field.options.mimeTypes}
/>
<div class="help-block">
<button type="button" class="inline-flex flex-gap-0">
<div
tabindex="0"
role="button"
aria-label="More collection options"
class="inline-flex flex-gap-0"
>
<span class="txt link-primary">Choose presets</span>
<i class="ri-arrow-drop-down-fill" />
<i class="ri-arrow-drop-down-fill" aria-hidden="true" />
<Toggler class="dropdown dropdown-sm dropdown-nowrap dropdown-left">
<button
type="button"
class="dropdown-item closable"
role="menuitem"
on:click={() => {
field.options.mimeTypes = [
"image/jpeg",
@@ -139,6 +145,7 @@
<button
type="button"
class="dropdown-item closable"
role="menuitem"
on:click={() => {
field.options.mimeTypes = [
"application/pdf",
@@ -154,6 +161,7 @@
<button
type="button"
class="dropdown-item closable"
role="menuitem"
on:click={() => {
field.options.mimeTypes = [
"video/mp4",
@@ -168,6 +176,7 @@
<button
type="button"
class="dropdown-item closable"
role="menuitem"
on:click={() => {
field.options.mimeTypes = [
"application/zip",
@@ -179,7 +188,7 @@
<span class="txt">Archives (zip, 7zip, rar)</span>
</button>
</Toggler>
</button>
</div>
</div>
</Field>
</div>
@@ -205,7 +214,7 @@
<span class="txt">Use comma as separator.</span>
<button type="button" class="inline-flex flex-gap-0">
<span class="txt link-primary">Supported formats</span>
<i class="ri-arrow-drop-down-fill" />
<i class="ri-arrow-drop-down-fill" aria-hidden="true" />
<Toggler class="dropdown dropdown-sm dropdown-center dropdown-nowrap p-r-10">
<ul class="m-0">
<li>